Keep using a single dividers LineCollection instance in colorbar. #17834
Conversation
| dividers : `.LineCollection` | ||
| A LineCollection if *drawedges* is ``True``, otherwise ``None``. | ||
| A LineCollection (empty if *drawedges* is ``False``). |
There was a problem hiding this comment.
Should this get an API change note?
There was a problem hiding this comment.
I don't think this is an API break because previously the attribute could be LineCollection or None, and now it's always LineCollection, so we don't add more types to handle.
There was a problem hiding this comment.
Technically, people could have checked cb.dividers is None, which now would have to be changed to not cb.dividers.
There was a problem hiding this comment.
sure, added changelog
|
This is a nice simplification. I don't find any test or example usage of the "drawedges" kwarg in any .py file in our repo. Searching for "drawedges" shows that it is also supported in axes_grid1/colorbar.py, which is deprecated as of 3.2. |
| self.dividers = None | ||
| self.dividers = collections.LineCollection( | ||
| [], | ||
| colors=[mpl.rcParams['axes.edgecolor']], |
There was a problem hiding this comment.
Doesn't this change the time of rcParams resolution from draw-time to init?
There was a problem hiding this comment.
The same "change in resolution time" occurred in #15981, where it is arguably a bugfix.
But sure, added to the changelog.
... updating its data as needed, instead of repeatedly deleting it and instantiating new ones.
... updating its data as needed, instead of repeatedly deleting it and
instantiating new ones.
Similar to #15981, just for another attribute.
PR Summary
PR Checklist