Skip to content

Fix example code for enabling logging in API change notice #18094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 28, 2020
Merged

Fix example code for enabling logging in API change notice #18094

merged 2 commits into from
Jul 28, 2020

Conversation

dopplershift
Copy link
Contributor

PR Summary

I stumbled across that API change when trying to figure out how to turn on logging. The code as provided does not work at all.

  • set_level doesn't exist -> setLevel
  • Nothing appears without setting a handler.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

@dopplershift
MNT: Fix example code to enable logging.
b76c798 
`set_level` doesn't exist, and nothing appears without a handler.
@dopplershift @timhoffm
Add comment about addHandler
5acdc22 
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
@QuLogic QuLogic added this to the v3.3-doc milestone Jul 28, 2020
@timhoffm
Copy link
Member

CI failure is due to pandas changing a warning (#18101); thus unrelated to this PR.

@timhoffm timhoffm merged commit 11d5b75 into matplotlib:master Jul 28, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jul 28, 2020
@dopplershift @meeseeksmachine
Backport PR matplotlib#18094: Fix example code for enabling logging i…
a280114 
…n API change notice
@meeseeksmachine meeseeksmachine mentioned this pull request Jul 28, 2020
Merged
@dopplershift dopplershift deleted the fix-api-change-logging branch July 29, 2020 00:19
QuLogic added a commit that referenced this pull request Jul 29, 2020
@QuLogic
Merge pull request #18105 from meeseeksmachine/auto-backport-of-pr-18…
9a7eae1 
…094-on-v3.3.0-doc

Backport PR #18094 on branch v3.3.0-doc (Fix example code for enabling logging in API change notice)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.3-doc
Development

Successfully merging this pull request may close these issues.
3 participants
@dopplershift @timhoffm @QuLogic