-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Use QuickLook instead of gs and inkscape on MacOS #18140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I had some failing tests locally, but let's see how it works in Travis |
5f6d4cd
to
37afee2
Compare
We might need to clear the cache of converted to png expected files? |
The cache keys are hashes that include the software version number. There are no version numbers for qlmanage, so I just used "qlmanage". This way the cached files from gs/inkscape shouldn't affect the tests. |
Would it make sense to insert the macOS version there, then? I don't expect a lot of people to have cache files from full system upgrades lying around, but maybe some kind of shared directory between VMs, or something. |
That makes sense, and AFAIK even full system upgrades leave your home directory alone so the cached files could still be there. |
The tests are now stopped by Travis timing out. The test run was not fast before, and skipping pdf and svg tests may have kept it under the Travis limit. #18134 installs dependencies without homebrew, and as a side effect makes the installation quite a bit faster. If that gets merged, let's try this again. |
qlmanage is built into MacOS since 10.5 and is faster to call than either of the alternatives
5869ed0
to
7286e90
Compare
Now we no longer time out, but there are plenty of image-comparison errors, most with small differences but in one test "RMS 19.782". |
That's a hatching one, which we often have trouble with depending on viewer, like #8289. I don't see any more current issues, though. |
This isn't passing, so I've marked as draft... |
Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it. |
qlmanage is built into MacOS since 10.5 and is faster to call than
either of the alternatives
PR Summary
PR Checklist