Fix axes -> Axes changes in figure.py #18820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
commented
Oct 26, 2020
| @@ -56,7 +56,7 @@ class _AxesStack(cbook.Stack): | |||
| Specialization of `.Stack`, to handle all tracking of `~.axes.Axes` in a | |||
| `.Figure`. | |||
|
|
|||
| This stack stores ``key, (ind, Axes)`` pairs, where: | |||
| This stack stores ``key, (ind, axes)`` pairs, where: | |||
There was a problem hiding this comment.
Usage in literals is similar to variables (rather than types) and thus should stay lowercase.
There was a problem hiding this comment.
Whoops I forgot to mention this in the comments. I wasn't sure about this one. Thanks for fixing.
There was a problem hiding this comment.
I thought it was fine, but I'm so old I remember when everyone was excited about mixed-case variable names (an improvement from all-caps!)
tacaswell
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Follow-up / correction of #18811.