Skip to content

Fix axes -> Axes changes in figure.py #18820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Fix axes -> Axes changes in figure.py #18820

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/matplotlib/figure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class _AxesStack(cbook.Stack):
Specialization of `.Stack`, to handle all tracking of `~.axes.Axes` in a
`.Figure`.

This stack stores ``key, (ind, Axes)`` pairs, where:
This stack stores ``key, (ind, axes)`` pairs, where:
Copy link
Member Author

@timhoffm timhoffm Oct 26, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usage in literals is similar to variables (rather than types) and thus should stay lowercase.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops I forgot to mention this in the comments. I wasn't sure about this one. Thanks for fixing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it was fine, but I'm so old I remember when everyone was excited about mixed-case variable names (an improvement from all-caps!)


* **key** is a hash of the args and kwargs used in generating the Axes.
* **ind** is a serial index tracking the order in which Axes were added.
Expand Down Expand Up @@ -141,7 +141,7 @@ def add(self, key, a):

def current_key_axes(self):
"""
Return a tuple of ``(key, Axes)`` for the active Axes.
Return a tuple of ``(key, axes)`` for the active Axes.

If no Axes exists on the stack, then returns ``(None, None)``.
"""
Expand Down Expand Up @@ -295,7 +295,7 @@ def autofmt_xdate(
"""
Date ticklabels often overlap, so it is useful to rotate them
and right align them. Also, a common use case is a number of
subplots with shared x-axes where the x-axis is date data. The
subplots with shared x-axis where the x-axis is date data. The
ticklabels are often long, and it helps to rotate them on the
bottom subplot and turn them off on other subplots, as well as
turn off xlabels.
Expand Down