-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add the ability to plot striped lines #19053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you add a PR summary or mark as draft if you are not ready for review yet? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, and welcome to Matplotlib!
Things to do:
- The comments below.
- Please fix the formatting issues flake8 complains about.
- Add a PR summary.
Discussion:
I'm a bit worried that the term offcolor
is too vague. Maybe something like dash_gap_color
?
Set the offcolor of the line. | ||
By default set at 'None' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set the offcolor of the line. | |
By default set at 'None' | |
Set the gap color for the dashed line style. |
offcolor : color or None | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
offcolor : color or None | |
""" | |
offcolor : color or None | |
The gap color. If None, the gaps are unfilled. | |
""" |
@lucielavigne do you plan to continue working on this? |
PR Summary
PR Checklist
pytest
passes).flake8
on changed files to check).flake8-docstrings
and runflake8 --docstring-convention=all
).doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).