Skip to content

Add the ability to plot striped lines #19053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

lucielavigne
Copy link

@lucielavigne lucielavigne commented Dec 1, 2020

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@story645 story645 linked an issue Dec 1, 2020 that may be closed by this pull request
@jklymak jklymak changed the title Add the ability to plot striped lines by Arnaud Remy, Lucie Lavigne Add the ability to plot striped lines Dec 2, 2020
@jklymak jklymak added this to the v3.5.0 milestone Dec 2, 2020
@jklymak
Copy link
Member

jklymak commented Dec 2, 2020

Can you add a PR summary or mark as draft if you are not ready for review yet?

Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, and welcome to Matplotlib!

Things to do:

  • The comments below.
  • Please fix the formatting issues flake8 complains about.
  • Add a PR summary.

Discussion:
I'm a bit worried that the term offcolor is too vague. Maybe something like dash_gap_color?

Comment on lines +1069 to +1070
Set the offcolor of the line.
By default set at 'None'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Set the offcolor of the line.
By default set at 'None'
Set the gap color for the dashed line style.

Comment on lines +1074 to +1075
offcolor : color or None
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
offcolor : color or None
"""
offcolor : color or None
The gap color. If None, the gaps are unfilled.
"""

@timhoffm
Copy link
Member

timhoffm commented Jan 3, 2021

@lucielavigne do you plan to continue working on this?

@jklymak jklymak marked this pull request as draft April 23, 2021 16:55
@QuLogic QuLogic modified the milestones: v3.5.0, v3.6.0 Aug 18, 2021
@timhoffm timhoffm modified the milestones: v3.6.0, unassigned Apr 30, 2022
rcomer added a commit to rcomer/matplotlib that referenced this pull request Jun 5, 2022
@rcomer rcomer mentioned this pull request Jun 5, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the ability to plot striped lines
5 participants