Skip to content

Deprecate cbook.warn_deprecated and move internal calls to _api.warn_deprecated #19162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2021
Merged

Deprecate cbook.warn_deprecated and move internal calls to _api.warn_deprecated #19162

merged 1 commit into from
Jan 5, 2021

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Dec 22, 2020 •
edited
Loading

PR Summary

Followup of moving all API helpers to matplotlib._api (#18657).

Builds on top of #19151.

  • still needs the actual deprecation.

@timhoffm timhoffm changed the title Change warn deprecated usage Deprecate cbook.warn_deprecated and move internal calls to _api.warn_deprecated Dec 22, 2020
@timhoffm timhoffm added this to the v3.4.0 milestone Dec 22, 2020
@timhoffm timhoffm force-pushed the change-warn_deprecated-usage branch 3 times, most recently from 2a1a943 to ecc851c Compare December 27, 2020 23:31
@timhoffm timhoffm marked this pull request as ready for review December 28, 2020 00:32
QuLogic
QuLogic approved these changes Jan 5, 2021
View reviewed changes
jklymak
jklymak approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyone can merge, but I won't if @timhoffm wants to address @QuLogic's suggestion...

@timhoffm timhoffm force-pushed the change-warn_deprecated-usage branch from ecc851c to 227c171 Compare January 5, 2021 19:56
@timhoffm timhoffm merged commit b2921c8 into matplotlib:master Jan 5, 2021
@timhoffm timhoffm deleted the change-warn_deprecated-usage branch January 5, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@timhoffm @QuLogic @jklymak