Skip to content

Remove remaining 3.3 deprecations #20465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 1, 2021

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Jun 19, 2021

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic
Copy link
Member Author

QuLogic commented Jun 19, 2021

OK, there are actually two more left, the global colour map dictionary, and global cmap modification. The latter is marked for removal in 3.6, but I'm not sure about the former.

@QuLogic
Copy link
Member Author

QuLogic commented Jun 19, 2021

Also, the cbook.get_sample_data deprecation never mentioned a removal version...

@anntzer
Copy link
Contributor

anntzer commented Jun 26, 2021

I think get_sample_data can just get its message tweaked and behavior change postponed for one version? It's not as if anything was urgent.


``MovieWriter`` attributes
~~~~~~~~~~~~~~~~~~~~~~~~~~
* ``animation.html_args`` rcParam
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* ``animation.html_args`` rcParam
* The rcParam ``animation.html_args`` has been removed.

IMHO for clarity, we should take the effort and make full sentences. Also in the following bullet points.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit lazier here because a) this is in the removal section, so it's implied, and b) I re-edit these when I put together final release notes and they may or may not be re-grouped, and then will get an overall sentence then.


Path helpers
~~~~~~~~~~~~
* ``bezier.make_path_regular``; use ``Path.cleaned()`` (or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* ``bezier.make_path_regular``; use ``Path.cleaned()`` (or
* ``bezier.make_path_regular`` has been removed. Use ``Path.cleaned()`` (or

@QuLogic QuLogic force-pushed the remove-33-deprecations branch from f0aa57b to b04f1a3 Compare June 29, 2021 09:29
@timhoffm timhoffm merged commit 9351d73 into matplotlib:master Jul 1, 2021
@QuLogic QuLogic deleted the remove-33-deprecations branch July 5, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants