Make date.{converter,interval_multiples} rcvalidators side-effect free. #21031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Register a custom unit conversion interface for dates that reads the relevant rc values when needed. This will allow having multiple rcParams instances existing at the same time, with only one of them actually being active and affecting the library's behavior.
7 tasks
timhoffm
approved these changes
Sep 9, 2021
jklymak
approved these changes
Sep 10, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 10, 2021
…} rcvalidators side-effect free.
dstansby
added a commit
that referenced
this pull request
Sep 10, 2021
…031-on-v3.5.x Backport PR #21031 on branch v3.5.x (Make date.{converter,interval_multiples} rcvalidators side-effect free.)
tacaswell
pushed a commit
that referenced
this pull request
Oct 20, 2021
Make date.{converter,interval_multiples} rcvalidators side-effect free.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Register a custom unit conversion interface for dates that reads the
relevant rc values when needed.
This will allow having multiple rcParams instances existing at the same
time, with only one of them actually being active and affecting the
library's behavior.
As discussed during the call; xref #21015.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).