Skip to content

Make rcParams["backend"] backend fallback check rcParams identity first. #21034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 9, 2021

This avoids accidentally triggering backend resolution via other
RcParams instances.

See #21015; #21031 is somewhat similar.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

This avoids accidentally triggering backend resolution via other
RcParams instances.
@jklymak
Copy link
Member

jklymak commented Sep 10, 2021

#21031 is merged - can you clarify the state of these PRs?

@anntzer
Copy link
Contributor Author

anntzer commented Sep 10, 2021

Sorry if I was unclear; this is doing the same thing as #21031 but for another rcparam and is thus also needed.

@timhoffm timhoffm added this to the v3.5.0 milestone Sep 16, 2021
@timhoffm timhoffm merged commit 86e19ad into matplotlib:master Sep 16, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 16, 2021
@anntzer anntzer deleted the rcb branch September 16, 2021 21:46
timhoffm added a commit that referenced this pull request Sep 17, 2021
…034-on-v3.5.x

Backport PR #21034 on branch v3.5.x (Make rcParams["backend"] backend fallback check rcParams identity first.)
tacaswell pushed a commit that referenced this pull request Oct 20, 2021
Make rcParams["backend"] backend fallback check rcParams identity first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants