Skip to content

More (minor) plot types gallery fixes. #21136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 23, 2021

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Sep 19, 2021

PR Summary

All changes are small. I thought it's ok to put them in a single PR to not run CI that often.

  • Include new plots into gallery ordering
  • Use a second style for plot types gallery entries without grid - to declutter the actual plotting code more (removes ax.grid(False)
  • Minor formatting fixes
  • Simplify unstructured data generation: There is no need to generate a regular grid and statistically choose points from that. Instead, we can immediately choose random points.

@timhoffm timhoffm added this to the v3.5.0 milestone Sep 19, 2021
@tacaswell
Copy link
Member

There is no problem renaming the style as it has not been released yet.

@timhoffm
Copy link
Member Author

Maybe we should claim the style for internal use only and name it _mpl-gallery?

@tacaswell
Copy link
Member

I can see arguments both ways. We use it as part of the user-facing docs so we should be able to change it at will so it should be private, but people may want to mimic and track the style and hence it should be public. Maybe a note someplace that we consider this style volatile?

There is no need to generate a regular grid and statistically choose
points from that. Instead, we can immediately choose random points.
@timhoffm
Copy link
Member Author

I can see arguments both ways. We use it as part of the user-facing docs so we should be able to change it at will so it should be private, but people may want to mimic and track the style and hence it should be public.

Both are not possible at the same time, in particular if change includes rename or delete. I don't see why it is critical for anybody to exactly track the style. It's not the end of the world if somebody copies it and doesn't immediately realize when we change. If they still want to track, I think setting up a CI up-to-date check on their side is the correct choice.
For now, I'll be defensive and claim the style to be explicitly private. We can always publicize it later when a compelling reason arises.

Co-authored-by: hannah <story645@gmail.com>
@jklymak
Copy link
Member

jklymak commented Sep 23, 2021

Anyone should merge once the build is done.

@jklymak jklymak merged commit afd0dcc into matplotlib:master Sep 23, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 23, 2021
jklymak added a commit that referenced this pull request Sep 23, 2021
…136-on-v3.5.x

Backport PR #21136 on branch v3.5.x (More (minor) plot types gallery fixes.)
@timhoffm timhoffm deleted the gallery-order branch September 23, 2021 10:53
tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull request Oct 12, 2021
More (minor) plot types gallery fixes.
tacaswell pushed a commit that referenced this pull request Oct 20, 2021
More (minor) plot types gallery fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants