-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
More (minor) plot types gallery fixes. #21136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There is no problem renaming the style as it has not been released yet. |
Maybe we should claim the style for internal use only and name it |
I can see arguments both ways. We use it as part of the user-facing docs so we should be able to change it at will so it should be private, but people may want to mimic and track the style and hence it should be public. Maybe a note someplace that we consider this style volatile? |
This declutters the code.
There is no need to generate a regular grid and statistically choose points from that. Instead, we can immediately choose random points.
16651fa
to
9dd1441
Compare
Both are not possible at the same time, in particular if change includes rename or delete. I don't see why it is critical for anybody to exactly track the style. It's not the end of the world if somebody copies it and doesn't immediately realize when we change. If they still want to track, I think setting up a CI up-to-date check on their side is the correct choice. |
Co-authored-by: hannah <story645@gmail.com>
Anyone should merge once the build is done. |
…136-on-v3.5.x Backport PR #21136 on branch v3.5.x (More (minor) plot types gallery fixes.)
More (minor) plot types gallery fixes.
More (minor) plot types gallery fixes.
PR Summary
All changes are small. I thought it's ok to put them in a single PR to not run CI that often.
ax.grid(False)