Cleanup contour(f)3d examples. #21166
Merged
+15
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Sep 24, 2021
Axes3D.clabel is a noop, so don't use it in examples (perhaps it should in fact throw a NotImplementedError, but let's not worry about that here). Various other small cleanups.
timhoffm
approved these changes
Sep 26, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 26, 2021
timhoffm
added a commit
that referenced
this pull request
Sep 26, 2021
…166-on-v3.5.x Backport PR #21166 on branch v3.5.x (Cleanup contour(f)3d examples.)
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Oct 12, 2021
Cleanup contour(f)3d examples.
tacaswell
pushed a commit
that referenced
this pull request
Oct 20, 2021
Cleanup contour(f)3d examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Axes3D.clabel is a noop, so don't use it in examples (perhaps it should
in fact throw a NotImplementedError, but let's not worry about that
here).
Various other small cleanups.
matplotlib/lib/mpl_toolkits/mplot3d/axes3d.py
Lines 974 to 976 in 7c2a3c4
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).