Skip to content

Cleanup contour(f)3d examples. #21166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2021
Merged

Cleanup contour(f)3d examples. #21166

merged 1 commit into from
Sep 26, 2021

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 24, 2021

Axes3D.clabel is a noop, so don't use it in examples (perhaps it should
in fact throw a NotImplementedError, but let's not worry about that
here).

Various other small cleanups.

def clabel(self, *args, **kwargs):
"""Currently not implemented for 3D axes, and returns *None*."""
return None

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Axes3D.clabel is a noop, so don't use it in examples (perhaps it should
in fact throw a NotImplementedError, but let's not worry about that
here).

Various other small cleanups.
@timhoffm timhoffm added this to the v3.5.0 milestone Sep 26, 2021
@timhoffm timhoffm merged commit ef96fef into matplotlib:master Sep 26, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 26, 2021
@anntzer anntzer deleted the c3 branch September 26, 2021 19:27
timhoffm added a commit that referenced this pull request Sep 26, 2021
…166-on-v3.5.x

Backport PR #21166 on branch v3.5.x (Cleanup contour(f)3d examples.)
tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull request Oct 12, 2021
Cleanup contour(f)3d examples.
tacaswell pushed a commit that referenced this pull request Oct 20, 2021
Cleanup contour(f)3d examples.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants