Skip to content

Fixed typos using codespell. (previous pull request was told not to change the agg files) #21186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 27, 2021
Merged

Fixed typos using codespell. (previous pull request was told not to change the agg files) #21186

merged 2 commits into from
Sep 27, 2021

Conversation

MalikIdreesHasanKhan
Copy link
Contributor

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

dstansby
dstansby previously requested changes Sep 27, 2021
View reviewed changes
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR - most of these look great, but we don't want to edit any of the files in the extern/ directory - could you undo those changes?

@MalikIdreesHasanKhan
Copy link
Contributor Author

Sure! Will do.

@MalikIdreesHasanKhan
Copy link
Contributor Author

I have done it. Please review it and tell me if anything remains to be undone.

@tacaswell tacaswell added this to the v3.5.0 milestone Sep 27, 2021
@timhoffm timhoffm dismissed dstansby’s stale review September 27, 2021 19:00

Request handled.

@timhoffm timhoffm merged commit 1794ddf into matplotlib:master Sep 27, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 27, 2021
@timhoffm @meeseeksmachine
Backport PR matplotlib#21186: Fixed typos using codespell. (previous …
3469e15 
…pull request was told not to change the agg files)
@meeseeksmachine meeseeksmachine mentioned this pull request Sep 27, 2021
Merged
@timhoffm
Copy link
Member

Thanks @MalikIdreesHasanKhan!

@MalikIdreesHasanKhan
Copy link
Contributor Author

My pleasure, @timhoffm !

timhoffm added a commit that referenced this pull request Sep 27, 2021
@meeseeksmachine @timhoffm
Backport PR #21186: Fixed typos using codespell. (previous pull reque…
72b0ebb 
…st was told not to change the agg files) (#21197)

Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull request Oct 12, 2021
@timhoffm
Merge pull request matplotlib#21186 from MalikIdreesHasanKhan/master
29857d6 
Fixed typos using codespell. (previous pull request was told not to change the agg files)
tacaswell pushed a commit that referenced this pull request Oct 20, 2021
@timhoffm
Merge pull request #21186 from MalikIdreesHasanKhan/master
937aa9a 
Fixed typos using codespell. (previous pull request was told not to change the agg files)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@timhoffm timhoffm timhoffm approved these changes

@dstansby dstansby Awaiting requested review from dstansby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@MalikIdreesHasanKhan @timhoffm @tacaswell @dstansby