Skip to content

Update fonts.rst #21196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 27, 2021
Merged

Update fonts.rst #21196

merged 2 commits into from
Sep 27, 2021

Conversation

fishmandev
Copy link
Contributor

Typo fix

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@@ -121,7 +121,7 @@ This is especially helpful to generate *really lightweight* documents.::
These core fonts are limited to PDF and PS backends only; they can not be
rendered in other backends.

Another downside to this is that while the font metric are standardized,
Another downside to this is that while the font metric is standardized,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Another downside to this is that while the font metric is standardized,
Another downside to this is that while the font metrics are standardized,

Agree there is a typo, but Ithink metric should be made plural rather than the verb being made singular?.

Copy link
Contributor Author

@fishmandev fishmandev Sep 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tacaswell, I agree with you. I've updated the PR.

@tacaswell tacaswell added this to the v3.5.0 milestone Sep 27, 2021
@tacaswell
Copy link
Member

Thanks for catching this @fishmandev !

Do you have thoughts on my proposed alternative?

@timhoffm timhoffm merged commit 9b3129e into matplotlib:master Sep 27, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 27, 2021
QuLogic added a commit that referenced this pull request Sep 27, 2021
…196-on-v3.5.x

Backport PR #21196 on branch v3.5.x (Update fonts.rst)
@tacaswell
Copy link
Member

Thank you @fishmandev ! Congratulations on what I believe that this was your first Matplotlib PR 🎉 and I also jut merged your second.

Hopefully we will hear from you again!

tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull request Oct 12, 2021
* Update fonts.rst

* Update fonts.rst
tacaswell pushed a commit that referenced this pull request Oct 20, 2021
* Update fonts.rst

* Update fonts.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants