-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Update fonts.rst #21196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fonts.rst #21196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers
or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
doc/users/fonts.rst
Outdated
@@ -121,7 +121,7 @@ This is especially helpful to generate *really lightweight* documents.:: | |||
These core fonts are limited to PDF and PS backends only; they can not be | |||
rendered in other backends. | |||
|
|||
Another downside to this is that while the font metric are standardized, | |||
Another downside to this is that while the font metric is standardized, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another downside to this is that while the font metric is standardized, | |
Another downside to this is that while the font metrics are standardized, |
Agree there is a typo, but Ithink metric should be made plural rather than the verb being made singular?.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tacaswell, I agree with you. I've updated the PR.
Thanks for catching this @fishmandev ! Do you have thoughts on my proposed alternative? |
…196-on-v3.5.x Backport PR #21196 on branch v3.5.x (Update fonts.rst)
Thank you @fishmandev ! Congratulations on what I believe that this was your first Matplotlib PR 🎉 and I also jut merged your second. Hopefully we will hear from you again! |
* Update fonts.rst * Update fonts.rst
* Update fonts.rst * Update fonts.rst
Typo fix