Fix freetype wheel building #21279
Merged
Fix freetype wheel building #21279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using just `CC` from the `distutils` compiler can break universal2 wheels on macOS, but passing all compiler and linker settings appears to work. Plus grabbing this information from `sysconfig` is better than hacking the `distutils` compiler into working.
PyPy doesn't have a host type, so don't pass `--host` in that case, and hope it is correct (which has been how it was since forever anyway.)
0db0e86 to
81730f7
Compare
tacaswell
approved these changes
Oct 5, 2021
jklymak
approved these changes
Oct 6, 2021
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove If these instruction are inaccurate, feel free to suggest an improvement. |
QuLogic
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 6, 2021
Fix freetype wheel building
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Oct 12, 2021
Fix freetype wheel building
tacaswell
pushed a commit
that referenced
this pull request
Oct 20, 2021
Fix freetype wheel building
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The changes in #21263 caused wheel builds to fail, which we didn't see because they aren't run on pull requests. I've made sure that wheel CI passes this time.
The problem is that setting
CConly is incomplete, and we need to set the linker, etc. It is better to grab that fromsysconfigrather than messing around with thedistutilscompiler that I originally did. Also, fix build on PyPy as well.PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).