Add GHA testing whether files were added and deleted in the same PR. #21359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
940ffb9 to
cdc9e73
Compare
timhoffm
approved these changes
Oct 14, 2021
|
I removed the other output. |
|
You can print out a special message which executes a workflow command, creating an annotation. I'm not sure how it looks if the annotation is on a file that is subsequently deleted. |
|
I'm not sure I really want to try (and loop over lines in bash, which I never remember how to do :-)), but you should feel free to do so :-) |
|
@anntzer this is ready. Please remove the test commits. |
|
Done. |
|
@meeseeksdev backport to v3.5.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 15, 2021
…d and deleted in the same PR.
jklymak
added a commit
that referenced
this pull request
Oct 15, 2021
…359-on-v3.5.x Backport PR #21359 on branch v3.5.x (Add GHA testing whether files were added and deleted in the same PR.)
tacaswell
pushed a commit
that referenced
this pull request
Oct 20, 2021
Add GHA testing whether files were added and deleted in the same PR.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Currently has two extra commits that test the functionality and should fail the workflow. Will remove these commits once we know this works.
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).