-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Relocate inheritance diagram to the top of the document #21491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers
or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am in favor of this, but I know @lgfunderburk is working on finding and moving additional diagrams at the pydata sprint so lets hold of merging this for a bit.
Could only find one more with the diagram at the bottom. One of the tests seems to fail. Please provide input on whether it failed due to how I rearranged items. Thank you! |
… of the document
Thank @lgfunderburk and congratulations on your first contribution to Matplotlib! W'd love to see you back! |
…491-on-v3.5.x Backport PR #21491 on branch v3.5.x (Relocate inheritance diagram to the top of the document)
Thank you @lgfunderburk , it was great to work with you at the pydata sprint! |
PR Summary
This PR moves the inheritance diagram from the bottom of the document, to the top of the document.
This is an initial PR to test rellocating the diagrams to the top.
This PR contributes to #7190
PR Checklist
pytest
passes).flake8
on changed files to check).flake8-docstrings
and runflake8 --docstring-convention=all
).doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).