Skip to content

Relocate inheritance diagram to the top of the document #21491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from Nov 3, 2021
Merged

Relocate inheritance diagram to the top of the document #21491

merged 2 commits into from Nov 3, 2021

Conversation

ghost
Copy link

@ghost ghost commented Oct 28, 2021

PR Summary

This PR moves the inheritance diagram from the bottom of the document, to the top of the document.
This is an initial PR to test rellocating the diagrams to the top.

This PR contributes to #7190

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@ghost ghost changed the title Relocate inheritance digram to the top of the document Relocate inheritance diagram to the top of the document Oct 28, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@tacaswell tacaswell added this to the v3.6.0 milestone Oct 28, 2021
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in favor of this, but I know @lgfunderburk is working on finding and moving additional diagrams at the pydata sprint so lets hold of merging this for a bit.

@QuLogic QuLogic added mentored: sprint Issues intended and suitable for sprints Documentation labels Oct 29, 2021
@story645 story645 added the status: needs workflow approval For PRs from new contributors, from which GitHub blocks workflows by default. label Nov 1, 2021
@ghost
Copy link
Author

ghost commented Nov 2, 2021

Could only find one more with the diagram at the bottom.

One of the tests seems to fail.

Please provide input on whether it failed due to how I rearranged items.

Thank you!

@timhoffm timhoffm removed the status: needs workflow approval For PRs from new contributors, from which GitHub blocks workflows by default. label Nov 3, 2021
@timhoffm timhoffm modified the milestones: v3.6.0, v3.5.0 Nov 3, 2021
@timhoffm timhoffm merged commit 8ba4f2b into matplotlib:main Nov 3, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 3, 2021
@timhoffm
Copy link
Member

timhoffm commented Nov 3, 2021

Thank @lgfunderburk and congratulations on your first contribution to Matplotlib! W'd love to see you back!

timhoffm added a commit that referenced this pull request Nov 3, 2021
…491-on-v3.5.x

Backport PR #21491 on branch v3.5.x (Relocate inheritance diagram to the top of the document)
@tacaswell
Copy link
Member

Thank you @lgfunderburk , it was great to work with you at the pydata sprint!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation mentored: sprint Issues intended and suitable for sprints
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants