MAINT Fix signature qhull version function #21834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
approved these changes
Dec 2, 2021
Yes. I can do that if you like. |
|
I think we should, if it doesn't introduce any warnings. |
jklymak
approved these changes
Dec 10, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Dec 10, 2021
jklymak
added a commit
that referenced
this pull request
Dec 10, 2021
…834-on-v3.5.x Backport PR #21834 on branch v3.5.x (MAINT Fix signature qhull version function )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This is more of the same function pointer cast removal maintenance, see #21628.
Now the problem is that the qhull version function is declared as taking no arguments, but is supposed to be a
METH_NOARGSfunction.METH_NOARGSfunctions should take twoPyObject*arguments. This tiny patch fixes that.