Remove unnecessary null checks in macosx.m, and some more maintenance #22109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FigureCanvas init already errors out if self->view is NULL, and,
more importanly, ObjC explicitly does allow calling methods ("sending
messages") on NULL (they just return NULL/0 in that case). Ditto for
FigureManager and self->window.
Unrelatedly, also remove unnecessary NULLs at the end of
PyObject_CallMethod calls (which are unneeded and in fact technically
wrong).
timhoffm
approved these changes
Jan 5, 2022
greglucas
approved these changes
Jan 5, 2022
There was a problem hiding this comment.
You've been doing so much macosx work now that you're re-using branch names ;) When I tested this out locally it complained about me already having this name. Maybe I'll just add your fork as a remote and pull directly next time :)
I tested the rubber band to be sure as well and all is good on that.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).