Add some tests for minspan{x,y} in RectangleSelector #22154
Conversation
139484a to
9501deb
Compare
| @pytest.mark.parametrize('minspany, y1', [[0, 10], [1, 10.5], [1, 11]]) | ||
| def test_rectangle_minspan(spancoords, minspanx, x1, minspany, y1): | ||
| ax = get_ax() | ||
| ax._n_onselect = 0 |
There was a problem hiding this comment.
AFAICS this dynamically adds an attribute. If so, this needs explanation:
| ax._n_onselect = 0 | |
| # add an attribute to track the number of onselect calls | |
| ax._n_onselect = 0 |
OTOH you are only working with a single axis. Couldn't you just use a local variable?
There was a problem hiding this comment.
I tried a local variable and it gives
def onselect(epress, erelease):
> n_onselect += 1
E UnboundLocalError: local variable 'n_onselect' referenced before assignmentI've added a comment though
There was a problem hiding this comment.
That would probably need a nonlocal statement. But I can live with a comment as well.
There was a problem hiding this comment.
Seems like a use case for Mock? Then assert_not_called, assert_called_once_with, etc.
There was a problem hiding this comment.
I'm happy to look into mocking, but would advocate for this PR to go in first so #21945 can be tested with these tests, and because the current code is how other widget tests do similar checks.
9501deb to
b093665
Compare
PR Summary
There aren't currently any tests for the
minspan{x,y}arguments, so add some. There isn't any public API for checking if a given selector is currently 'active', so I had to use the privatetool._selection_completedflag for that.PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).