Replace sole use of maxdict by lru_cache. #22323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
:) You can bring the deprecation over here if you want, happy to close the other PR. While you're at it, do you want to add a test here to make sure we are hitting the cache as expected since I made the mistake on the other one that would only cache on each text instance? |
|
Done (^2) |
greglucas
approved these changes
Jan 26, 2022
| @@ -0,0 +1,4 @@ | |||
| ``matplotlib.cbook.maxdict`` is deprecated | |||
6 tasks
da764ff to
44d21ac
Compare
|
Edit: modified the implementation to not use pickle but instead key off an internally generated copy of fontprop (which the caller cannot access and thus cannot mutate). |
timhoffm
approved these changes
Jan 26, 2022
lib/matplotlib/text.py
Outdated
Comment on lines
96
to
97
| # the passed-in argument do not mess up the cache. dpi is not used, but | ||
| # participates in cache invalidation (via the renderer). |
There was a problem hiding this comment.
Suggested change
| # the passed-in argument do not mess up the cache. dpi is not used, but | |
| # participates in cache invalidation (via the renderer). | |
| # the passed-in argument do not mess up the cache. |
Move that note down, because dpi is only passed on here. Clever tools will show unused in the function below and people might be tempted to remove it without consulting the context of the call site.
QuLogic
reviewed
Jan 27, 2022
... and expand the cache size, while we're at it.
It was used in one place in the library and there is now a standard library lru_cache that we can take advantage of instead.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and expand the cache size, while we're at it.
Actual deprecation of maxdict can be done in #22299.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).