Skip to content

Really fix wheel building on CI #22549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Feb 24, 2022

PR Summary

I had the wrong condition in #22375, so that they were still not triggered on push.

This time I've done a full check of the PR cycle on my fork, including labelling, re-opening, and merging.

PR Checklist

Tests and Styling

  • [n/a] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).

I had the wrong condition in matplotlib#22375, so that they were still not
triggered on push.
@QuLogic QuLogic added the Build label Feb 24, 2022
@QuLogic QuLogic added this to the v3.5.2 milestone Feb 24, 2022
@dstansby dstansby merged commit f440d2b into matplotlib:main Feb 24, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Feb 24, 2022
@QuLogic QuLogic deleted the fix-wheels branch February 24, 2022 21:53
oscargus added a commit that referenced this pull request Feb 24, 2022
…549-on-v3.5.x

Backport PR #22549 on branch v3.5.x (Really fix wheel building on CI)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants