Fixed installation guide command typo #23009
Conversation
|
I also noticed that the installation document uses Is this intentional? If not, I can standardize that as apart of this PR. |
| @@ -281,11 +281,11 @@ be manually installed on Macports with :: | |||
| Once pip is installed, you can install Matplotlib and all its dependencies with | |||
| from the Terminal.app command line:: | |||
|
|
|||
| python3 -mpip install matplotlib | |||
| python3 -m pip install matplotlib | |||
|
|
|||
| (``sudo python3.6 ...`` on Macports). | |||
There was a problem hiding this comment.
Some Mac person (@greglucas I have identified as one) can probably tell if there is a better thing than 3.6 to write here.
There was a problem hiding this comment.
I now realize that the whole section is about OSX, so probably I should stop reviewing...
But my, not very qualified, guess is that you are doing the right thing.
There was a problem hiding this comment.
After reading up a bit:
- Both
-mpipand-m pipworks, but consistency is nice. - OSX comes with 2.7 as default
pythonso for the OSX parts it should bepython3.
There was a problem hiding this comment.
I didn't realize -mpip was valid.
In that case, maintainers can decide whether consistency warrants a change. I'm OK with it either way.
@oscargus Thank you for looking into both of those issues!
There was a problem hiding this comment.
Let's always use -m pip. While I personally leave out the space when typing, separating the parameter and it's argument is more clear.
There was a problem hiding this comment.
There is most definitely a better thing than 3.6 to use because we don't support 3.6 anymore 😄 We should probably change all of the python3.x to python3 everywhere... Unfortunately, mac is still only shipping with python2 by default (on my recently upgraded system at least), so python is not good enough here.
|
For simplicity, I merge this as is. If there is interest in sorting out the |
PR Summary
I'm think
python -mpip ...is supposed to bepython -m pip ...in both of the cases in the installation guide.PR Checklist
Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).