-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
DOC: do not suggest to sudo pip install Matplotlib #23024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -291,8 +291,6 @@ from the Terminal.app command line:: | |||
|
|||
python3 -m pip install matplotlib | |||
|
|||
(``sudo python3.6 ...`` on Macports). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(``port install py-matplotlib`` on Macports).
seems like a correct replacement.
https://apple.stackexchange.com/questions/282839/using-pip-vs-macports-for-installing-python-packages
https://ports.macports.org/port/py-matplotlib/details/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just drop this altogether? We don't give instructions for apt or other package managers, do we? I think we should doc pip and conda and if someone wants to install with macports they can ask macports how to do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We give basic installation commands (like sudo apt install python-matplotlib
) for some package managers, but little package-manager specific setup instructions.
This does seem to be a common problem for OSX users, so maybe it might be worth leaving in the installation guide and adding @oscargus suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I somewhat disagree, or at the least we need to rephrase the docs here. If I was a naive user who had not really heard of conda I'd skip the conda section (what's that?) and go to the MacOS section. Then I would be using crazy macports or brew installs, or worse trying to use the system python, when really by far the easiest solution on a Mac (or most other platforms) is to use conda. All this stuff should be hidden behind links that say "manual OS-specific installs, not recommended".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging as an improvement. Reorganizing the sections/adding brew and macport things can be done in a follow-up PR.
PR Summary
Skimming the discussion in #23009 I noticed that we are suggesting to use sudo + pip to install things 😱 which is something that you should never do.
PR Checklist
Tests and Styling
pytest
passes).flake8-docstrings
and runflake8 --docstring-convention=all
).Documentation
doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).