-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
DOC: do not suggest to sudo pip install Matplotlib #23024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like a correct replacement.
https://apple.stackexchange.com/questions/282839/using-pip-vs-macports-for-installing-python-packages
https://ports.macports.org/port/py-matplotlib/details/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just drop this altogether? We don't give instructions for apt or other package managers, do we? I think we should doc pip and conda and if someone wants to install with macports they can ask macports how to do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We give basic installation commands (like
sudo apt install python-matplotlib
) for some package managers, but little package-manager specific setup instructions.https://github.com/matplotlib/matplotlib/blob/main/doc/users/installing/index.rst#linux-package-manager
This does seem to be a common problem for OSX users, so maybe it might be worth leaving in the installation guide and adding @oscargus suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I somewhat disagree, or at the least we need to rephrase the docs here. If I was a naive user who had not really heard of conda I'd skip the conda section (what's that?) and go to the MacOS section. Then I would be using crazy macports or brew installs, or worse trying to use the system python, when really by far the easiest solution on a Mac (or most other platforms) is to use conda. All this stuff should be hidden behind links that say "manual OS-specific installs, not recommended".