Make draw_gouraud_triangle
optional and remove unused versions
#23820
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #23819
Clarify that it is enough to implement one of
draw_gouraud_triangle
anddraw_gouraud_triangles
in a backend and that anyArtist
should call the latter.Remove unused versions of
draw_gouraud_triangle
.I assume that there should be some sort of note here clarifying the changed behaviour (in practice that any custom artists should call
draw_gouraud_triangles
). Including the example code:I do not really see a way to deprecate this, without really deprecating
draw_gouraud_triangle
completely (and instead introduce something like_draw_gouraud_triangle
which wouldn't really fit well with the general structure). It would be possible to deprecate the now removed versions though. A quick search show that https://github.com/ArduPilot/MAVProxy uses a copy of the backend_agg.py-file which has it included, but that is the only thing I could find which may cause anyone some problem.PR Checklist
Tests and Styling
pytest
passes).flake8-docstrings
and runflake8 --docstring-convention=all
).Documentation
doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).