Skip to content

Deprecate draw_gouraud_triangle #23824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2022
Merged

Deprecate draw_gouraud_triangle #23824

merged 2 commits into from
Sep 17, 2022

Conversation

oscargus
Copy link
Member

@oscargus oscargus commented Sep 8, 2022 •
edited
Loading

PR Summary

Closes #23820 #23819

Main benefit, see more above, is that we can remove code which is now effectively dead.

PR Checklist

Tests and Styling

  • [N/A] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@timhoffm timhoffm added this to the v3.7.0 milestone Sep 9, 2022
QuLogic
QuLogic reviewed Sep 16, 2022
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know @anntzer is aware of this, but would just like to confirm that this won't break mplcairo.

@anntzer
Copy link
Contributor

anntzer commented Sep 16, 2022

mplcairo only ever defined the plural form, so it's fine here.

@tacaswell @QuLogic
DOC: minor rewording
d0a1e0c 
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@timhoffm timhoffm merged commit 4a5d09c into matplotlib:main Sep 17, 2022
@QuLogic QuLogic mentioned this pull request Sep 17, 2022
Closed
@oscargus oscargus deleted the gourauddeprecation branch September 17, 2022 20:30
melissawm pushed a commit to melissawm/matplotlib that referenced this pull request Dec 19, 2022
@oscargus @tacaswell
@QuLogic @melissawm
Deprecate draw_gouraud_triangle (matplotlib#23824)
11104dd 
* Deprecate draw_gouraud_triangle

* DOC: minor rewording

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>

Co-authored-by: Thomas A Caswell <tcaswell@gmail.com>
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic left review comments

@tacaswell tacaswell tacaswell approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
API: changes
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@oscargus @anntzer @tacaswell @QuLogic @timhoffm