Transform ParasiteAxesBase._update_viewlim into standard callback. #24529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1f4c144 to
3a7f6db
Compare
update_viewlim as an independent method was deprecated in da2f77a and has since then been removed. We could just inline _update_viewlim into apply_aspect, but transforming it into a callback on xlim_changed/ylim_changed helps moving towards the removal of ParasiteAxes as a separate class and its replacement by standard (child) axes with some extra attributes/callbacks set.
oscargus
approved these changes
Nov 23, 2022
QuLogic
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update_viewlim as an independent method was deprecated in da2f77a and
has since then been removed. We could just inline _update_viewlim into
apply_aspect, but transforming it into a callback on
xlim_changed/ylim_changed helps moving towards the removal of
ParasiteAxes as a separate class and its replacement by standard (child)
axes with some extra attributes/callbacks set.
PR Summary
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst