Skip to content

Revert "Merge pull request #24555 from parthpankajtiwary/symlog-warn" #26126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

tacaswell
Copy link
Member

This reverts commit 041d4e0, reversing changes made to fbfa28d.

Closes #26118

PR summary

PR checklist

…mlog-warn"

This reverts commit 041d4e0, reversing
changes made to fbfa28d.

Closes matplotlib#26118
@tacaswell tacaswell added this to the v3.7.2 milestone Jun 14, 2023
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if we want such a warning, this is too low-level for it.

In general I don't think we can reliably say if the user needs this warning or not.

@QuLogic
Copy link
Member

QuLogic commented Jun 15, 2023

This reverts commit 041d4e0, reversing changes made to fbfa28d.

I'm not sure what this has to do with the latter commit?

Edit: Ah, I guess it's saying the reverted changes are with respect to that latter commit, as opposed to the other side of the merge.

@QuLogic QuLogic merged commit 49f657a into matplotlib:main Jun 15, 2023
@lumberbot-app
Copy link

lumberbot-app bot commented Jun 15, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.7.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 49f657a564f1e103d1748326c072ea1503fe0b42
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #26126: Revert "Merge pull request #24555 from parthpankajtiwary/symlog-warn"'
  1. Push to a named branch:
git push YOURFORK v3.7.x:auto-backport-of-pr-26126-on-v3.7.x
  1. Create a PR against branch v3.7.x, I would have named this PR:

"Backport PR #26126 on branch v3.7.x (Revert "Merge pull request #24555 from parthpankajtiwary/symlog-warn")"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: symlog scale generates false warning when mouse is moved
3 participants