-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Revert "Merge pull request #24555 from parthpankajtiwary/symlog-warn" #26126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…mlog-warn" This reverts commit 041d4e0, reversing changes made to fbfa28d. Closes matplotlib#26118
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if we want such a warning, this is too low-level for it.
In general I don't think we can reliably say if the user needs this warning or not.
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
…4555 from parthpankajtiwary/symlog-warn"
This reverts commit 041d4e0, reversing changes made to fbfa28d.
Closes #26118
PR summary
PR checklist