Skip to content

Make test_save_animation_smoketest actually run #2679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 20, 2013
Merged

Make test_save_animation_smoketest actually run #2679

merged 4 commits into from
Dec 20, 2013

Conversation

tacaswell
Copy link
Member

The @cleanup decorator turns the generator into a class and the tests don't actually get run

Marked mencoder as KnownFailure as it currently fails, see issue #2678, everything else passes locally.

@pelson
Copy link
Member

pelson commented Dec 18, 2013

Python3.3 error with the test suite:

======================================================================
ERROR: matplotlib.tests.test_animation.test_save_animation_smoketest('imagemagick', 'gif')
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.3/lib/python3.3/site-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/home/travis/virtualenv/python3.3/lib/python3.3/site-packages/matplotlib-1.4.x-py3.3-linux-x86_64.egg/matplotlib/tests/test_animation.py", line 55, in check_save_animation
    anim.save(F.name, fps=30, writer=writer)
  File "/home/travis/virtualenv/python3.3/lib/python3.3/site-packages/matplotlib-1.4.x-py3.3-linux-x86_64.egg/matplotlib/animation.py", line 725, in save
    writer.grab_frame(**savefig_kwargs)
  File "/home/travis/virtualenv/python3.3/lib/python3.3/site-packages/matplotlib-1.4.x-py3.3-linux-x86_64.egg/matplotlib/animation.py", line 210, in grab_frame
    dpi=self.dpi, **savefig_kwargs)
  File "/home/travis/virtualenv/python3.3/lib/python3.3/site-packages/matplotlib-1.4.x-py3.3-linux-x86_64.egg/matplotlib/figure.py", line 1439, in savefig
    self.canvas.print_figure(*args, **kwargs)
  File "/home/travis/virtualenv/python3.3/lib/python3.3/site-packages/matplotlib-1.4.x-py3.3-linux-x86_64.egg/matplotlib/backend_bases.py", line 2196, in print_figure
    self.figure.dpi = origDPI
  File "/home/travis/virtualenv/python3.3/lib/python3.3/site-packages/matplotlib-1.4.x-py3.3-linux-x86_64.egg/matplotlib/figure.py", line 400, in _set_dpi
    self.dpi_scale_trans.clear().scale(dpi, dpi)
  File "/home/travis/virtualenv/python3.3/lib/python3.3/site-packages/matplotlib-1.4.x-py3.3-linux-x86_64.egg/matplotlib/transforms.py", line 1790, in clear
    self._mtx = np.identity(3)
  File "/home/travis/virtualenv/python3.3/lib/python3.3/site-packages/numpy/core/numeric.py", line 2053, in identity
    from numpy import eye
  File "<frozen importlib._bootstrap>", line 1610, in _handle_fromlist
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xff in position 0: invalid start byte

----------------------------------------------------------------------

@tacaswell
Copy link
Member Author

It is failing on importing from numpy. I restarted the test (and the 2.7 test which errored out) to see if it was something silly going on with travis installing.

@tacaswell
Copy link
Member Author

That error is consistent and above my pay grade.

Googling the last couple lines of the traceback points to #1891 which I have re-opened as we now have an existing test on travis that shows this issue.

@pelson
Copy link
Member

pelson commented Dec 19, 2013

I think we are going to have to put a known fail if python 33 on this so that we can move this PR forwards. We should add a comment on the corresponding issue to this effect also.

Thanks for linking them together @tacaswell.

@tacaswell
Copy link
Member Author

Dealt with it with a try/catch instead of an explicit version check.

Also added libav-tools to the list of packages installed so something other than gif tests run.

The error seems to be only in the streaming saves, not the write to files and stitch together saves.

pelson added a commit that referenced this pull request Dec 20, 2013
@pelson
Merge pull request #2679 from tacaswell/fix_animation_tests
263c1b9 
Make `test_save_animation_smoketest` actually run
@pelson pelson merged commit 263c1b9 into matplotlib:master Dec 20, 2013
@pelson
Copy link
Member

pelson commented Dec 20, 2013

Thanks @tacaswell. Would you mind adding a note in the linked issue so that we remember to remove these known fails?

@tacaswell
Copy link
Member Author

Done.

I think I lost a comment some place as I remember writing a message on why I was reopening that issue that seems to not exist, sorry about that.

@tacaswell tacaswell deleted the fix_animation_tests branch February 8, 2014 04:44
@tacaswell tacaswell mentioned this pull request Jan 15, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tacaswell @pelson