Bump setuptools required version because of setuptools_scm v8 #26849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69b1188 to
d7f3bcc
Compare
|
Hopefully this resolves the azure test failures |
Technically could work with older setuptools and setuptools_scm==7, but encoding that matrix of dependencies is not something I think is worth worrying about, and setuptools 64 is over a year old (though not by a _whole_ lot).
d7f3bcc to
c70a52e
Compare
timhoffm
approved these changes
Sep 21, 2023
|
This should probably fall under https://matplotlib.org/stable/devel/min_dep_policy.html#test-and-documentation-dependencies "test and documentation" rules and setuptools 64 was release August 2022 so we are good. I have some concern that we are going to make problems for people who want to build "old" numpy (prior to them adopting meson) and us in the same environment as we are pinning to setuptools >=64 and numpy used to pin to setuptools <60. However, hopefully we will land our move to meson soon and this will be moot so merging. |
|
Leaning to backport because we will have to unbreak it for any bug-fix releases even though we are probably not going to backport the meson work. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 21, 2023
…e of setuptools_scm v8
efiring
added a commit
that referenced
this pull request
Oct 4, 2023
…849-on-v3.8.x Backport PR #26849 on branch v3.8.x (Bump setuptools required version because of setuptools_scm v8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Technically could work with older setuptools and setuptools_scm==7,
but encoding that matrix of dependencies is not something I think is worth worrying about,
and setuptools 64 is over a year old (though not by a whole lot).
setuptools_scm has a version constraint that they do not themselves enforce on the environment
so I've added it to our own requirements, when setuptools_scm is required.
Setuptools_scm's docs are inconsistent in what version they actually require, so I went with
the one that was most up to date and was in their user facing docs.
(My next choice would be 61, as that is what the runtime warning actually checks)
The config in pyproject.toml was taken from #26621
Closes #26846
PR checklist