ci: Run mypy against typed cycler #26943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
216de6b to
b7ac555
Compare
|
Un-drafted now that typed cycler is out. |
oscargus
approved these changes
Oct 2, 2023
|
We have the Which is somewhat odd because matplotlib/cycler#88 specifically mentions that file (in the sdist) I can confirm that building locally the file is not included... |
|
I've opened matplotlib/cycler#98 in response |
|
OK, I've made a new cycler release with those changes included, and updated |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 11, 2023
story645
added a commit
that referenced
this pull request
Oct 12, 2023
…943-on-v3.8.x Backport PR #26943 on branch v3.8.x (ci: Run mypy against typed cycler)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This tests against the new cycler release candidate, and then drops the flag/comment noted in the ci config.
PR checklist