Skip to content

[Doc]: Move Automated Tests section to workflow docs #26998 #27093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 15, 2023

Conversation

guru2605
Copy link
Contributor

PR summary

Fixes #26998

  • Moved Automated Tests to Workflow doc
  • Added a reference for automated tests in the current place

PR checklist

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@story645 story645 added this to the v3.8-doc milestone Oct 15, 2023
@story645 story645 added the Documentation: devdocs files in doc/devel label Oct 15, 2023
Copy link
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I added a short sentence adding some context, you're welcome to make that change or leave it for a follow up. Just let me know.

Co-authored-by: hannah <story645@gmail.com>
Copy link
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the html has to build. Look at our codespaces if you can't/don't want to build locally
https://matplotlib.org/devdocs/devel/contribute.html#how-to-contribute

Co-authored-by: hannah <story645@gmail.com>
@guru2605 guru2605 requested a review from story645 October 15, 2023 05:34
Copy link
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight spacing nit but otherwise good to go.

Co-authored-by: hannah <story645@gmail.com>
@story645
Copy link
Member

Congrats on your first merged PR 🥳 we hope to see you again!

@guru2605
Copy link
Contributor Author

Thank you @story645 . Definitely looking forward to do more contributions.

story645 added a commit that referenced this pull request Oct 15, 2023
…093-on-v3.8.x

Backport PR #27093 on branch v3.8.x ([Doc]: Move Automated Tests section to workflow docs #26998)
story645 added a commit that referenced this pull request Oct 15, 2023
…093-on-v3.8.0-doc

Backport PR #27093 on branch v3.8.0-doc ([Doc]: Move Automated Tests section to workflow docs #26998)
@ksunden ksunden mentioned this pull request Nov 2, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation: devdocs files in doc/devel
Projects
Development

Successfully merging this pull request may close these issues.

[Doc]: Move Automated Tests section to workflow docs
2 participants