Add ten-color accessible color cycle as style sheet #27851
Conversation
|
I am very much in favor of taking this, but agree the name needs some workshopping. We may also want to add these sequence(s) to matplotlib/lib/matplotlib/colors.py Lines 119 to 132 in cb8c484 |
|
If it is ready in the next week or so, it can go in 3.9, but I think it is important to get the names and such rather rather than rushing it through. |
|
@mpetroff great to see this! As a user, I am in favor of adding the 6- and 8-color cycles. |
There was a problem hiding this comment.
Given the discussion in mpetroff/accessible-color-cycles#1 this PR would adopt the petroffX name scheme.
2db5b79 to
c886314
Compare
|
I took the liberty of accepting the naming change, adding it to the sequence registry, and fixing the rebase. |
|
@mpetroff can we get an approval from you that you're good with the name changes discussed in mpetroff/accessible-color-cycles#1 that were adopted here? |
Yes, I'm good with it. |
|
@tacaswell @mpetroff Can we rebase this off |
Color cycle survey palette from Petroff (2021): https://arxiv.org/abs/2107.02270 https://github.com/mpetroff/accessible-color-cycles
See discussion in mpetroff/accessible-color-cycles#1 Co-authored-by: Matthew Feickert <matthew.feickert@cern.ch>
c886314 to
ff584d7
Compare
There was a problem hiding this comment.
This can be done in a followup, but would be nice if this got added to the following for discoverability:
-
https://matplotlib.org/devdocs/users/explain/colors/colormaps.html
-
https://matplotlib.org/devdocs/gallery/style_sheets/index.html
ETA: also I'm really psyched this is going in, thanks for your work on this folks!
|
I went ahead and merged this and opened issue for the additional examples / documentation. |
|
Thank you @mpetroff ! |
PR summary
(Following up from email.)
Adds a style sheet with the ten-color color cycle survey palette from Petroff (2021) [which will be published in a journal eventually]:
https://arxiv.org/abs/2107.02270
https://github.com/mpetroff/accessible-color-cycles
Related to (but does not fix) #9460.
At the moment, this PR contains only the minimal changes. I've only added the ten-color sequence from the paper and only done so as a style sheet.
The paper additionally contains six- and eight-color sequences, which could also be added.
Would it be better to add to
_BUILTIN_COLOR_SEQUENCESinlib/matplotlib/colors.pywith data inlib/matplotlib/_cm.pyinstead of as a style sheet?I'm also open to naming suggestions. The current name is the placeholder I've been using, with
ccsstanding for "color cycle survey".PR checklist