-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Followup documentation for petroff color sequence #28750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Good first issue - notes for new contributorsThis issue is suited to new contributors because it does not require understanding of the We do not assign issues. Check the Development section in the sidebar for linked pull If something is unclear, please reach out on any of our communication |
Good first issue b/c minimally it's adding one string |
But we added these as color sequences not as categorical color maps. |
For some reason I thought we'd moved all the categoricals to color sequences, but if not then this issue should be to create user documentation/ a new user guide page for the color sequence registry and using it b/c that doesn't really exist. It's still an ok first issue b/c it's fairly standalone -> new page in colors section of user guide -> but more work. |
@story645 Can you either edit the initial post or leave a comment with details about what you have in mind? |
I think we made all of the discrete color maps available as sequences, but did not remove them as color maps. With |
is this issue still open can i work on it? |
Yes, this documentation hasn't been created yet and you're welcome to create it. |
May I know what is |
'petroff10' is the matplotlib name for the new color Petroff color sequence and how it is accessed in code. |
Hey, is the issue still open, would love to contribute? |
Note that issues don't get assigned or claimed: https://matplotlib.org/devdocs/devel/contribute.html#work-on-an-issue matplotlib/doc/devel/contribute.rst Lines 246 to 251 in 5461ae2
So go for it. 👍 Though reading the contributing docs (https://matplotlib.org/devdocs/devel/contribute.html) is a good first step. |
I was trying to set up a dev environment for matplotlib. Finally, figured it out: had to switch from Windows to Linux. So, I'll working on this issue now. |
Is the issue still opened? I want to contribute to it |
@hwii-florescent Yeah, I worked on the first task. You can get started on the second task:
|
I am willing to take on the second task. Could you provide more context on what exactly needs to be done? |
Here's my understanding. The page the second task links to has this in its description
As of now, the page doesn't explore the color sequences — as in how you can customize the color maps and make your information more accessible by using different style sheets. So, if we have a separate page for that, it would be helpful to Matplotlib users. That's all I know. |
Hello, is this issue completed yet? Am I able to work on it as my first issue - maybe finish off what others left if its still open? |
@u7228810 Yes, the second task hasn't been attempted yet. That said, if it's your very first contribution, I would suggest starting with a difficulty: easy task. |
FWIW I'm clueless on the difference, I thought that the listings on this page were exhaustive! https://matplotlib.org/devdocs/users/explain/colors/colormaps.html Unclear to me how to use this new coloring without changing the whole style sheet. |
We have both
Example usages:
|
@ammar-quzi Hello does Second task still open ?? pls let me know |
@SHRISHTISHUKLA-0 Yes, the second task is still open. |
Okay I want to work on this
Thank you)
…On Thu, 30 Jan, 2025, 11:12 pm ammar-qazi, ***@***.***> wrote:
@SHRISHTISHUKLA-0 <https://github.com/SHRISHTISHUKLA-0> Yes, the second
task is still open.
—
Reply to this email directly, view it on GitHub
<#28750 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMQRG5XLZJU7EK5GHU3UTO32NJQBBAVCNFSM6AAAAABM6L3IDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRVGE3DINJQGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Can you please help to know about second issue deeply it will help to
understand what exactly and where I have to work!!
…On Thu, 30 Jan, 2025, 11:12 pm ammar-qazi, ***@***.***> wrote:
@SHRISHTISHUKLA-0 <https://github.com/SHRISHTISHUKLA-0> Yes, the second
task is still open.
—
Reply to this email directly, view it on GitHub
<#28750 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMQRG5XLZJU7EK5GHU3UTO32NJQBBAVCNFSM6AAAAABM6L3IDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRVGE3DINJQGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Color sequences are named lists of colors that can be used for style sheets, cycler objects and as lists of colors. colors/index is the section of the docs that explains colors and it's missing a page on sequences. If you've never worked with color sequences or don't see a need to, then you may not have the context necessary for writing this documentation. |
hello I think that I can able to solve this is but here I can't able to link PR why? |
please tell me why I am not able to get PR link after push ?? what should I do now?? |
The error message indicates that you are trying to push to matplotlib's
repository rather than your fork. Make sure you follow the developer
guidance to help you get started:
https://matplotlib.org/devdocs/devel/development_workflow.html
…On Fri, Jan 31, 2025 at 2:42 AM Shrishti Shukla ***@***.***> wrote:
@SHRISHTISHUKLA-0 <https://github.com/SHRISHTISHUKLA-0> Yes, the second
task is still open.
please tell me why I am not able to get PR link after push ??
its showing error ( remote: permission to matplotlib/matplotlib.git denied
to SHRISHTISHUKLA-0 fatal: unable to access '
http://github.com/matplotlib/matplotlib.git/'.The
<https://github.com/matplotlib/matplotlib.git/'.The> requested URL
returned error: 403
what should I do now??
—
Reply to this email directly, view it on GitHub
<#28750 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACHF6DP3V3A5YDVOAXG6OL2NMSN7AVCNFSM6AAAAABM6L3IDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRWGQ4TOMJVG4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
ooh thank you as firstyear student first time I'm contributing in open sources and pr that's why I having lot of doubts. |
This can be done in a followup, but would be nice if this got added to the following for discoverability:
* https://matplotlib.org/devdocs/users/explain/colors/colormaps.html* https://matplotlib.org/devdocs/gallery/color/colormap_reference.html#sphx-glr-gallery-color-colormap-reference-pyETA: also I'm really psyched this is going in, thanks for your work on this folks!
Originally posted by @story645 in #27851 (review)
The text was updated successfully, but these errors were encountered: