Skip to content

Add example of petroff10 in the style sheets to show how to use the color sequence. #28796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

ammar-qazi
Copy link
Contributor

PR summary

Add example of petroff10 in practice to resolve the first part of #28750.

@github-actions github-actions bot added the Documentation: examples files in galleries/examples label Sep 9, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our stylesheet examples are somewhat inconsistent. We have an overview in https://matplotlib.org/stable/gallery/style_sheets/style_sheets_reference.html#sphx-glr-gallery-style-sheets-style-sheets-reference-py and some additional explicit examples at the top level https://matplotlib.org/stable/gallery/index.html#style-sheets.

We should consolidate that at some point. But for now, this is a good addition as it draws a little more attention to the new style.

@timhoffm timhoffm merged commit 029b026 into matplotlib:main Sep 11, 2024
21 checks passed
@timhoffm
Copy link
Member

Thanks @ammar-qazi and congratulations on your first merged PR for matplotlib! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation: examples files in galleries/examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants