DOC: Switch nested pie example from cmaps to color_sequences #29120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it clearer that we are just indexing into a list of colors. Calling cmaps with an integer argument is somewhat obscure and we want to move away from this. See also matplotlib#28198.
rcomer
approved these changes
Nov 11, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 11, 2024
…ps to color_sequences
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 11, 2024
…ps to color_sequences
|
Something went wrong ... Please have a look at my logs. It seems that the branch you are trying to backport to does not exist. |
|
I guess we didn’t make a 3.10-doc branch yet. |
timhoffm
added a commit
that referenced
this pull request
Nov 11, 2024
…120-on-v3.10.x Backport PR #29120 on branch v3.10.x (DOC: Switch nested pie example from cmaps to color_sequences)
timhoffm
added a commit
that referenced
this pull request
Nov 11, 2024
…120-on-v3.9.x Backport PR #29120 on branch v3.9.x (DOC: Switch nested pie example from cmaps to color_sequences)
No, it's an open issue #28750 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it clearer that we are just indexing into a list of colors. Calling cmaps with an integer argument is somewhat obscure and we want to move away from this. See also #28198.