Skip to content

ci: MacOS 14: temporarily upper-bound the 'PyGObject' Python package version #29734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jayaddison
Copy link
Contributor

@jayaddison jayaddison commented Mar 11, 2025

PR summary

GitHub Actions recently began failing for MacOS 14, as reported in #29732.

From experimentation in this branch, it seems that Python PyGObject package versions v3.52.0 and beyond introduce a compatibility issue that causes the test failures; this pull request pins the package version below that.

PR checklist

Resolves #29732 (with a short-term fix).

Edit: rewrite description for brevity

@greglucas
Copy link
Contributor

@jayaddison I just want to say thank you for digging into all of this and all of your investigations and debugging! It is great to see your desire to improve Matplotlib and dig into some annoying/confusing dependency issues to help out the project. I just want to explicitly call this out to you since sometimes these contributions can go unrecognized.

@jayaddison jayaddison changed the title ci: temporarily upper-bound the 'PyGObject' Python package version ci: MacOS 14: temporarily upper-bound the 'PyGObject' Python package version Mar 11, 2025
@jayaddison jayaddison marked this pull request as ready for review March 12, 2025 00:17
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@timhoffm timhoffm added this to the v3.10-doc milestone Mar 12, 2025
@timhoffm timhoffm merged commit 502cdd1 into matplotlib:main Mar 12, 2025
37 of 38 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 12, 2025
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 12, 2025
dstansby added a commit that referenced this pull request Mar 12, 2025
…734-on-v3.10.1-doc

Backport PR #29734 on branch v3.10.1-doc (ci: MacOS 14: temporarily upper-bound the 'PyGObject' Python package version)
@jayaddison jayaddison deleted the issue-29732/temporary-pygobject-version-upper-bound branch March 12, 2025 14:34
@jayaddison
Copy link
Contributor Author

Thanks @timhoffm @dstansby!

@jayaddison
Copy link
Contributor Author

@timhoffm @dstansby sorry - it seems I broke something with this. I see the following message in a recent mainline build log:

/Users/runner/work/_temp/23206c06-98f5-4a60-b559-09a6ba02d11e.sh: line 31: 3.52.0: No such file or directory

Oddly the MacOS 14 tests do pass; but not for the expected reason (pinning the version), it seems.

@jayaddison
Copy link
Contributor Author

And the reason is that I've introduced a shell redirection (the <3.52.0 becomes a read-from-file-named 3.52.0 ...)

@dstansby
Copy link
Member

Woops, my bad for not checking properly before merging - it looks like the failing test is being skipped. I've fixed this in #29748, lets see if the tests pass 🤞

dstansby added a commit that referenced this pull request Mar 13, 2025
…734-on-v3.10.x

Backport PR #29734 on branch v3.10.x (ci: MacOS 14: temporarily upper-bound the 'PyGObject' Python package version)
@ksunden ksunden mentioned this pull request May 9, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Unit tests: MacOS 14 failures: gi-invoke-error-quark
4 participants