-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
ci: MacOS 14: temporarily upper-bound the 'PyGObject' Python package version #29734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: MacOS 14: temporarily upper-bound the 'PyGObject' Python package version #29734
Conversation
@jayaddison I just want to say thank you for digging into all of this and all of your investigations and debugging! It is great to see your desire to improve Matplotlib and dig into some annoying/confusing dependency issues to help out the project. I just want to explicitly call this out to you since sometimes these contributions can go unrecognized. |
…, to minimize CI resource" This reverts commit 8d62733.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
…he 'PyGObject' Python package version
…he 'PyGObject' Python package version
…734-on-v3.10.1-doc Backport PR #29734 on branch v3.10.1-doc (ci: MacOS 14: temporarily upper-bound the 'PyGObject' Python package version)
@timhoffm @dstansby sorry - it seems I broke something with this. I see the following message in a recent mainline build log:
Oddly the MacOS 14 tests do pass; but not for the expected reason (pinning the version), it seems. |
And the reason is that I've introduced a shell redirection (the |
Woops, my bad for not checking properly before merging - it looks like the failing test is being skipped. I've fixed this in #29748, lets see if the tests pass 🤞 |
…734-on-v3.10.x Backport PR #29734 on branch v3.10.x (ci: MacOS 14: temporarily upper-bound the 'PyGObject' Python package version)
PR summary
GitHub Actions recently began failing for MacOS 14, as reported in #29732.
From experimentation in this branch, it seems that Python
PyGObject
package versions v3.52.0 and beyond introduce a compatibility issue that causes the test failures; this pull request pins the package version below that.PR checklist
new and changed code is testedN/APlotting related features are demonstrated in an exampleN/ANew Features and API Changes are noted with a directive and release noteN/ADocumentation complies with general and docstring guidelinesN/AResolves #29732 (with a short-term fix).
Edit: rewrite description for brevity