-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
DOC: Slightly further improve arrowstyle demo #29801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
timhoffm
commented
Mar 24, 2025
•
edited
Loading
edited
- use straight lines for the arrows - the previous curved lines are distracting since this is only about the arrowstyle
- use monospace font for the style names
- adjust positions and colors so that the arrows stand out more
Note: doc build failure is likely unrelated, see #29802. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kinda want a box around each entry but not sure that it would make things clearer.
l, = ax.plot(1, 0, "o", color="grey") | ||
ax.annotate(stylename, (1, 0), (0, 0), | ||
size="large", color="tab:blue", ha="center", va="center", | ||
l, = ax.plot(1.25, 0, "o", color="lightgrey") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be like one or two shades darker?
9c01223
to
3323b92
Compare
what about a faded or dotted grid? I like the boundaries but I get how here it starts looking cluttered |
Feel free to play around if you like. But I think if we add boxes, we need another approach to the titles. They don't really make sense in large boxes. |
The boxes don't really work there. At most, I'd say a line down the middle could work. |
I wouldn't include boxes. I'd add a bit more wspace between the columns. Why are AngleA and AngleB all specified in these but set to zero? The constructor for the axs is needlessly complex. |
galleries/examples/text_labels_and_annotations/fancyarrow_demo.py
Outdated
Show resolved
Hide resolved
Do you mean the parameter blocks in the rendered figure? That's
|
- use straight lines - use monospace font for the style names - adjust positions and colors so that the arrows stand out more
3323b92
to
1c39a10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to self merge if you feel you've dealt with everything.
…801-on-v3.10.x Backport PR #29801 on branch v3.10.x (DOC: Slightly further improve arrowstyle demo)
…801-on-v3.10.1-doc Backport PR #29801 on branch v3.10.1-doc (DOC: Slightly further improve arrowstyle demo)