Skip to content

DOC: Slightly further improve arrowstyle demo #29801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Mar 24, 2025

  • use straight lines for the arrows - the previous curved lines are distracting since this is only about the arrowstyle
  • use monospace font for the style names
  • adjust positions and colors so that the arrows stand out more

@github-actions github-actions bot added the Documentation: examples files in galleries/examples label Mar 24, 2025
Copy link
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kinda want a box around each entry but not sure that it would make things clearer.

l, = ax.plot(1, 0, "o", color="grey")
ax.annotate(stylename, (1, 0), (0, 0),
size="large", color="tab:blue", ha="center", va="center",
l, = ax.plot(1.25, 0, "o", color="lightgrey")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be like one or two shades darker?

@timhoffm
Copy link
Member Author

timhoffm commented Mar 25, 2025

I kinda want a box around each entry but not sure that it would make things clearer.

Not sure that's better. It looks more imbalanced because the number of parameters vary strongly.

grafik

@story645
Copy link
Member

what about a faded or dotted grid? I like the boundaries but I get how here it starts looking cluttered

@timhoffm
Copy link
Member Author

Feel free to play around if you like. But I think if we add boxes, we need another approach to the titles. They don't really make sense in large boxes.

@QuLogic
Copy link
Member

QuLogic commented Mar 26, 2025

The boxes don't really work there. At most, I'd say a line down the middle could work.

@jklymak
Copy link
Member

jklymak commented Mar 26, 2025

I wouldn't include boxes. I'd add a bit more wspace between the columns.

Why are AngleA and AngleB all specified in these but set to zero?

The constructor for the axs is needlessly complex.

@timhoffm
Copy link
Member Author

Why are AngleA and AngleB all specified in these but set to zero?

Do you mean the parameter blocks in the rendered figure? That's

Each style can be configured with a set of parameters, which are stated along with
their default values.

- use straight lines
- use monospace font for the style names
- adjust positions and colors so that the arrows stand out more
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to self merge if you feel you've dealt with everything.

@timhoffm timhoffm added this to the v3.10-doc milestone Mar 27, 2025
@timhoffm timhoffm merged commit 05663f7 into matplotlib:main Mar 27, 2025
22 checks passed
@timhoffm timhoffm deleted the doc-arrowstyle branch March 27, 2025 23:14
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 27, 2025
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 27, 2025
QuLogic added a commit that referenced this pull request Mar 28, 2025
…801-on-v3.10.x

Backport PR #29801 on branch v3.10.x (DOC: Slightly further improve arrowstyle demo)
QuLogic added a commit that referenced this pull request Mar 28, 2025
…801-on-v3.10.1-doc

Backport PR #29801 on branch v3.10.1-doc (DOC: Slightly further improve arrowstyle demo)
@ksunden ksunden mentioned this pull request May 9, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation: examples files in galleries/examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants