Skip to content

Fix typos: horizonatal -> horizontal #29979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

Conversation

martincornejo
Copy link
Contributor

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@tacaswell tacaswell added this to the v3.10.2 milestone Apr 28, 2025
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second reviewer should verify my understanding that this is affecting the typing machinery and bringing it inline with the current API, NOT changing the API (as if we really have a miss-spelling in our API we need to run the normal deprecation cycle).

@rcomer
Copy link
Member

rcomer commented Apr 28, 2025

The second reviewer should verify my understanding that this is affecting the typing machinery and bringing it inline with the current API, NOT changing the API (as if we really have a miss-spelling in our API we need to run the normal deprecation cycle).

Agreed. Function would raise if the miss-spelling was passed

_api.check_in_list(["horizontal", "vertical"], orientation=orientation)

Copy link
Member

@rcomer rcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @martincornejo!

@rcomer rcomer merged commit 919d9e9 into matplotlib:main Apr 28, 2025
39 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants