-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Fix typos: horizonatal -> horizontal #29979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second reviewer should verify my understanding that this is affecting the typing machinery and bringing it inline with the current API, NOT changing the API (as if we really have a miss-spelling in our API we need to run the normal deprecation cycle).
Agreed. Function would raise if the miss-spelling was passed matplotlib/lib/matplotlib/axes/_axes.py Line 7513 in 828ec6f
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @martincornejo!
No description provided.