Skip to content

Overhaul make.osx in master #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

jkseppan
Copy link
Member

@jkseppan jkseppan commented Mar 6, 2011

This is the master branch counterpart to pull request #17, which fixes some problems in make.osx on the v1.0.x maintenance branch. In addition to the changes on that branch, this pull request updates zlib, freetype and libpng to new versions.

@jkseppan
Copy link
Member Author

jkseppan commented Mar 6, 2011

Some tests fail with new freetype - see http://thread.gmane.org/gmane.comp.python.matplotlib.devel/9948/focus=9965

The echo was there to comment out a cp command, and things seem to
work fine without the cp.
Conflicts:
	README.osx
	make.osx
@jkseppan
Copy link
Member Author

Went back to an older freetype because of the failing tests, and merged master because of a conflict. Comments, anyone?

@ddale
Copy link
Contributor

ddale commented Apr 2, 2011

I don't use the makefile approach myself. I use MacPorts to provide the dependencies and then the usual "python setup.py install --user". I might recommend adding an additional install target like "mpl_install_user", to support installing to user's local site-packages directory (python-2.6 and newer).

Aside from that, the only comment I have is that I would have stuck with the newer freetype, it is going to be provided by other package managers anyway.

@mdboom
Copy link
Member

mdboom commented Apr 4, 2011

Perhaps as part of this effort we should merge the two different Mac OS X makefiles in the tree? (Or as a follow on.) Just wanted to link this mailing list discussion here:

http://www.mail-archive.com/matplotlib-devel@lists.sourceforge.net/msg08055.html

@efiring
Copy link
Member

efiring commented Jun 16, 2011

I think this really should get merged now, before the next release, and I agree with Mike that it should have the new freetype version. However, I have been unsuccessful in doing the merge. Every time I try, README.osx gets truncated. I could use a brute-force method, simply copying the revised versions of the two files from the branch into master and committing, but maybe someone else can figure out a more elegant solution.

@ddale
Copy link
Contributor

ddale commented Jun 16, 2011

Yeah, I see the same thing. Rebasing yields the same result. I'd like to understand what is going on, github says this pull request can be automatically merged, but when I perform the merge locally there are conflicts that have to be resolved. Jouni, why did you merge master into this branch?

@ddale
Copy link
Contributor

ddale commented Jun 16, 2011

Maybe its not worth worrying about, and we should just do the brute-force approach. I'm not at work today where I can test on a mac. Eric, could you take care of it? Are you familiar with 'git commit --author="Jouni K. Seppänen jks@iki.fi"'?

@efiring
Copy link
Member

efiring commented Jun 16, 2011

On 06/16/2011 03:06 AM, ddale wrote:

Maybe its not worth worrying about, and we should just do the brute-force approach. I'm not at work today where I can test on a mac. Eric, could you take care of it? Are you familiar with 'git commit --author="Jouni K. Seppänenjks@iki.fi"'?

Now I am!
I will do it this afternoon.

jkseppan added a commit that referenced this pull request Jun 16, 2011
Slightly modified version of a71414d from the maintenance branch.
@efiring
Copy link
Member

efiring commented Jun 16, 2011

Closed with 861da23.

@efiring efiring closed this Jun 16, 2011
mdboom added a commit to mdboom/matplotlib that referenced this pull request Oct 31, 2011
mdboom added a commit to mdboom/matplotlib that referenced this pull request Oct 31, 2011
Flush buffer when finishing SVG file.  Closes matplotlib#30.
@richbwood richbwood mentioned this pull request Dec 19, 2012
magnunor pushed a commit to magnunor/matplotlib that referenced this pull request Dec 5, 2013
…ib#30

lib/io/dm3_data_plugin.py
BUG-FIX: DM3ImageFile.read_image_data
         when loading data, the natural order should be (rows, columns, ...)
         and not (X, Y, ...).

         Digital Micrograph stores Spectrum Images as:

         X0, Y0, Z0,
         X1, Y0, Z0,
         [...],
         Xn, Ym, Z0,
         [...]
         X0, Y0, Z1,
         [...],
         Xn, Ym, Zk

         Since X <=> column and Y <=> row the 1st two axes of the ndarray
         must be transposed because the natural order is:
         row (Y), column (X), E.

MOVE:   file_reader
        For back compatibility with the plotting libraries, the data are
        transposed back.
magnunor pushed a commit to magnunor/matplotlib that referenced this pull request Dec 5, 2013
… The digital micrograph

reader has been almost fully rewritten and it should now be able to read
a higher number of dm3 files.
nansonzheng pushed a commit to nansonzheng/matplotlib that referenced this pull request Mar 5, 2016
fariza added a commit to fariza/matplotlib that referenced this pull request Sep 22, 2016
making figure legend for profiles
@jkseppan jkseppan deleted the master-make-osx branch January 2, 2017 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants